Skip to content

Conversation

mythmon
Copy link
Member

@mythmon mythmon commented Sep 12, 2024

This makes sure that Poetry is installed and that it can successfully install dependencies. Normally Poetry makes and manages its own virtualenvs, but we don't really want that here. The bulk of the new tests validate that when Poetry installs dependencies it does it in the existing virtualenv. It does this because we already have an activated virtualenv in the Docker image.

@Fil
Copy link
Contributor

Fil commented Sep 13, 2024

I've recently discovered pipenv which could be a nice addition too.

Copy link
Contributor

@jessedearing jessedearing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I wrote a quick Python test app using poetry and it worked.

@mythmon mythmon merged commit a977bbb into main Sep 13, 2024
1 check passed
@mythmon mythmon deleted the mythmon/240912/poetry branch September 13, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants